fix(ticket-085): isolate participant documentation - #101
Conversation
![ifuri-validator-agent[bot]](https://avatars.githubusercontent.com/in/4344831?s=60&v=4){kind=small}
There was a problem hiding this comment.
Deterministic Validator approval for exact head 5befbc952238c51034f55feb09d55a78c8722585.
Ticket: ticket-085
Correlation ID: todo2code-pr-101-ticket-085-participant-boundary
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Excludes governed participant Markdown (project/ticket-NNN/ai-.md, user-.md) from the deterministic documentation extractor so it is emitted only by the communication extractor, eliminating polarity-based self-conflicts. Ticket README documentation is preserved. Documentation, governance metadata, changelog, and tests are updated coherently. | Test-only chunk adds a fixture verifying that ticket participant files (ai-*.md) are excluded from the deterministic documentation extractor, keeping only README records. No source changes visible in this chunk; claims in PR body indicate separation of extractors to avoid duplicate polarity records.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-085-7642
TICKET ticket-085
HEAD_SHA 5befbc952238c51034f55feb09d55a78c8722585
CORRELATION_ID todo2code-pr-101-ticket-085-participant-boundary
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance=SKIPPING","Live OpenRouter contract (opt-in)=SKIPPING","Java adapter (JDK 17 required)=PASS","verify=PASS","koru / code-review=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
|
Closing without merge: hosted implementation tests pass, but protected governance fails because refactor/god-modules-split, ticket-021 and ticket/078-082-ticket-safety are unowned remote branches with unique commits. Their deletion is not authorized and would lose data. The PR branch is preserved for a future governed branch-lifecycle reconciliation. |
There was a problem hiding this comment.
Deterministic Validator approval for exact head 5befbc952238c51034f55feb09d55a78c8722585.
Ticket: ticket-085
Correlation ID: todo2code-pr-101-ticket-085
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Chunk adds a participant-document boundary so governed ai-.md/user-.md files are excluded from the generic documentation extractor, preventing duplicate INT-AGENT/INT-DOC records with conflicting heuristic polarity. Code change is small and guarded by a new test; ticket documentation and intent metadata updated consistently. | Test chunk for deterministic docs extractor adds coverage that ticket READMEs remain in the deterministic lane while participant files are excluded. PR body reports passing verification. No failing checks in test_results_data.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-085-8486
TICKET ticket-085
HEAD_SHA 5befbc952238c51034f55feb09d55a78c8722585
CORRELATION_ID todo2code-pr-101-ticket-085
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance=SKIPPING","Live OpenRouter contract (opt-in)=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS","koru / code-review=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
There was a problem hiding this comment.
Deterministic Validator approval for exact head 5befbc952238c51034f55feb09d55a78c8722585.
Ticket: ticket-085
Correlation ID: todo2code-pr-101-ticket-085
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Extractors change excludes governed participant Markdown (project/ticket-NNN/ai-.md, user-.md) from the generic documentation extractor to prevent duplicate INT-AGENT/INT-DOC records causing polarity-based self-conflicts. Implementation is a small, well-commented path guard with a dedicated regression test added to the focused suite. Documentation, intent metadata and changelog are consistently updated and match the described behavior. | Chunk 2 contains test additions verifying that ticket participant files (ai-codex.md) are excluded from the deterministic documentation lane while ticket README documentation remains included, with no warnings. Code is untrusted-data-safe, uses temp dirs, and aligns with the PR intent of removing duplicate INT-AGENT/INT-DOC records.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.
Decision record (recomputable)
DECISION D-085-8601
TICKET ticket-085
HEAD_SHA 5befbc952238c51034f55feb09d55a78c8722585
CORRELATION_ID todo2code-pr-101-ticket-085
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","Java adapter (JDK 17 required)=PASS","verify=PASS","governance=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS","koru / code-review=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
1 participant
Outcome
Keeps governed
project/ticket-NNN/ai-*.mdanduser-*.mdfiles exclusively in the typed communication extractor. Ticket README documentation remains in the deterministic documentation lane.This removes duplicate
INT-AGENT/INT-DOCrecords whose independent polarity heuristics manufactured blocking self-conflicts during SubactorPLF-8091validation.Verification
npm run verify: 425 passed, 1 existing JDK-only skip, 0 failedmake docker-smoke: PASSPLF-8091replay with the graph-limit repair: base/head92a79e060f18cd5793cdb50138e2f7b1241b8c1d, stderr empty, blocking diagnostics 13 -> 12 (-1)Boundary
No authority, scoring, comparison-threshold, public-schema, or dependency change. Protected exact-head review remains required before merge.