Skip to content

fix(ticket-085): scope documentation criteria to source ticket - #99

Merged
ifuri-validator-agent[bot] merged 2 commits into
mainfrom
fix/ticket-085-ticket-doc-scope
Aug 25, 2026
Merged

fix(ticket-085): scope documentation criteria to source ticket#99
ifuri-validator-agent[bot] merged 2 commits into
mainfrom
fix/ticket-085-ticket-doc-scope

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Summary

  • bind deterministic records under project/ticket-NNN/** to their source ticket
  • prevent local AC-01 labels from colliding across unrelated tickets
  • preserve explicit non-criterion ticket references

Verification

  • focused docs suite: 6/6
  • npm run verify: 424 passed, 1 existing JDK-only skip
  • make docker-smoke
  • governance and diff checks

Ticket: ticket-085

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head 7cd4b2cd4fa6d7d3a4c0575275cd726edeb966f7.

Ticket: ticket-085
Correlation ID: todo2code-pr-99-ticket-085
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: REQUEST_CHANGES
Advisory summary: Reviewed all 2 diff chunk(s). Chunk 1 of 2: governance scaffolding for ticket-085 and start of extractor change scoping criterion-only documentation records to their source ticket. Code change looks reasonable but is truncated mid-hunk; the new helper sourceTicketOf and updated record constructors are not visible in this chunk, so correctness cannot be fully assessed here. All reported checks pass. | Change binds documentation records under project/ticket-NNN to a namespaced source ticket, filtering bare AC-N labels so they don't collide globally, while preserving explicit ticket references. Test coverage added and all checks pass.
Advisory findings: LLM verdict was REQUEST_CHANGES
The LLM output above is advisory and was not used as the approval trust root.
Merge will be attempted after this approval when explicitly authorized.

Decision record (recomputable)

DECISION D-085-4778
TICKET ticket-085
HEAD_SHA 7cd4b2cd4fa6d7d3a4c0575275cd726edeb966f7
CORRELATION_ID todo2code-pr-99-ticket-085
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","Java adapter (JDK 17 required)=PASS","verify=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "REQUEST_CHANGES" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit ea6ce38 into main Aug 25, 2026
12 of 13 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the fix/ticket-085-ticket-doc-scope branch August 25, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant