Skip to content

ci(fork-tests): skip Base Std checks on forked PRs - #4249

Open
meyer9 wants to merge 1 commit into
mainfrom
meyer9/skip-std-checks-on-forks
Open

ci(fork-tests): skip Base Std checks on forked PRs#4249
meyer9 wants to merge 1 commit into
mainfrom
meyer9/skip-std-checks-on-forks

Conversation

@meyer9

@meyer9 meyer9 commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Skip Base Std Interface Tests for pull requests from forks
  • Document that we don't have permission to comment on forked PRs
  • Still run on same-repo PRs, merge queue, and workflow_dispatch

@meyer9 @cursoragent
ci(fork-tests): skip Base Std checks on forked PRs
6a921c3 
We don't have permission to comment on forked PRs, so skip the workflow
for external contributor pull requests.

Co-authored-by: Cursor <cursoragent@cursor.com>
@cb-heimdall

cb-heimdall commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No issues found. The if conditions correctly gate both the fork-tests matrix job and the aggregate job on same-repo PRs, while preserving behavior for merge_group and workflow_dispatch events. The always() in the aggregate condition is properly parenthesized to avoid running the aggregation step when fork-tests is skipped for forked PRs.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Base Std historical fork tests

Fork Result Passed Failed Skipped base/base base-anvil base-std
Beryl pass 616 0 13 f0757968 6d744e03 4658f1b7
Cobalt pass 703 0 14 f0757968 ae7557c4 96e96870

View run

refcell
refcell reviewed Aug 3, 2026
View reviewed changes

@refcell refcell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we just skip commenting on prs from forks rather than skipping base std tests entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@refcell refcell refcell left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@meyer9 @cb-heimdall @refcell