fix(protocol-versions): allow equal activation timestamps - #389
Merged
Conversation
Collaborator
✅ Heimdall Review Status
|
PelleKrab
requested review from
0xth4nh and
Copilot
and removed request for
Copilot
July 31, 2026 19:34
Co-authored-by: Codex <codex-noreply@coinbase.com>
PelleKrab
force-pushed
the
fix/protocol-versions-allow-equal-timestamps
branch
from
July 31, 2026 19:39
076fe07 to
5b97bd8
Compare
0xth4nh
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Loosens
ProtocolVersionstimestamp ordering from strictly increasing to non-decreasing for previous scheduled upgrades.
Motivation
This supports testnets/devnets that activate multiple upgrades at genesis with the
same timestamp.
Behavior
0remains the unscheduled value and is skipped by ordering checks.>=the closest previous scheduled timestamp.