Skip to content

fix(protocol-versions): allow equal activation timestamps - #389

Merged
PelleKrab merged 1 commit into
mainfrom
fix/protocol-versions-allow-equal-timestamps
Jul 31, 2026
Merged

fix(protocol-versions): allow equal activation timestamps#389
PelleKrab merged 1 commit into
mainfrom
fix/protocol-versions-allow-equal-timestamps

Conversation

@PelleKrab

Copy link
Copy Markdown
Contributor

Summary

Loosens ProtocolVersions timestamp ordering from strictly increasing to non-
decreasing for previous scheduled upgrades.

Motivation

This supports testnets/devnets that activate multiple upgrades at genesis with the
same timestamp.

Behavior

  • 0 remains the unscheduled value and is skipped by ordering checks.
  • Non-zero timestamps must be >= the closest previous scheduled timestamp.
  • Timestamps before the previous scheduled upgrade still revert.
  • The existing strict check against the next scheduled upgrade is unchanged.

@cb-heimdall

cb-heimdall commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Co-authored-by: Codex <codex-noreply@coinbase.com>
@PelleKrab
PelleKrab force-pushed the fix/protocol-versions-allow-equal-timestamps branch from 076fe07 to 5b97bd8 Compare July 31, 2026 19:39
@PelleKrab
PelleKrab merged commit db08d3a into main Jul 31, 2026
6 checks passed
@PelleKrab
PelleKrab deleted the fix/protocol-versions-allow-equal-timestamps branch July 31, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants