Enforce invisibility online-only and redact laser paths for concealed opponents - #72
Merged
bashmohandes merged 1 commit intoAug 16, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
invisibilitypower-up and make the inventory UI reflect the rule.Description
invisibilityentry inPOWER_UP_CATALOGwith anonlineOnlyflag inbattle-tanks/scripts/game.js.syncInventoryUI inbattle-tanks/scripts/app.jsto render online-only pickups as disabled and labeled, and added a defensive guard inusePowerUpto block local activation.stateForinserver/battle-tanks-rooms.jsby clearinglaserPathand removingpathfromimpactsandlastImpactfor a concealed opponent.tests/battle-tanks-page.test.jsand a server-side laser-redaction test intests/battle-tanks-rooms.test.jsthat assert owner-visible vs viewer-redacted laser fields.Testing
npm run checkand it completed successfully with no errors.npm testand all tests passed (no failures).npm test -- --test-name-pattern='Battle Tanks|viewer-aware|laser path|power-up'and the matching tests passed (no failures).Codex Task