Battle Tanks: exclude online-only power-ups locally, continue pickups, improve fullscreen controls and result UI

[bashmohandes]

Motivation

• Players reported online-only power-ups appearing in local mode and local matches stopping power-up spawns after a while.
• On iPhone full screen in landscape the on-screen controls were covering the arena.
• The end-of-game winner UI was small and hard to notice and should be a prominent card with Rematch and Share actions.

Description

• Add a local pickup whitelist and prevent onlineOnly items from spawning when state.onlineMode is false by introducing LOCAL_PICKUP_IDS and guarding spawnPickup for requested/auto picks. (battle-tanks/scripts/game.js).
• Remove the artificial 18-turn cutoff so pickups continue to spawn every SPAWN_EVERY_TURNS for long matches by changing advancePickupSchedule. (battle-tanks/scripts/game.js).
• Mark authoritative online rooms with room.game.onlineMode = true and preserve onlineMode across rematches by carrying it through resetMatch. (server/battle-tanks-rooms.js, battle-tanks/scripts/game.js).
• Replace the tiny corner winner controls with a centered result dialog built in DOM and wired to the app, and update app.js to populate and toggle the result card content and visibility. (battle-tanks/index.html, battle-tanks/scripts/app.js).
• Add styles and responsive rules for the animated result card and reserve a control strip for very short landscape viewports so full-screen controls do not cover tanks on iPhones. (battle-tanks/styles.css).
• Add regression tests for local pickup filtering, continued pickup scheduling in long matches, and preservation of onlineMode on rematch. (tests/battle-tanks.test.js, tests/battle-tanks-rooms.test.js).

Testing

• Ran npm run check and it completed successfully with no syntax errors reported.
• Ran the full test suite with npm test, all automated tests passed (166 tests reported passing).
• Ran git diff --check to ensure there are no whitespace or diff-check problems and it succeeded.

---

Codex Task

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 145bd0aba1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Allow the result card to scroll in short arenas

On narrow non-fullscreen phones, the 16:9 arena can be only about 200px tall, while this card's icon, text, padding, and 48px actions require substantially more height. Because the parent arena has overflow:hidden, this layer does not scroll, and the card itself also uses overflow:hidden, the Rematch and Share buttons are clipped and inaccessible; the previous rematch button outside the arena was removed in this change. Add a short-height layout or vertical scrolling so the sole rematch control remains reachable.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Move keyboard focus into the result dialog

When a keyboard user ends the match from the Fire button, unhiding this aria-modal dialog leaves focus on the now-disabled Fire control outside it, and forward tab order proceeds to other outside controls because the result card occurs earlier in the DOM. Screen-reader users are therefore not reliably notified that the modal opened, and keyboard navigation does not enter its Rematch/Share actions as expected. Detect the game-over transition, focus the rematch button, and keep focus within the modal while it is displayed.

Useful? React with 👍 / 👎.