Keep Battle Tanks result actions reachable in short arenas - #76
Merged
Merged
Conversation
bashmohandes
changed the base branch from
codex/fix-power-ups-display-in-local-mode
to
master
August 16, 2026 20:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
overflow:hiddenand the arena parent hasoverflow:hidden; the result UI must remain reachable (Rematch/Share) on small viewports.Description
.result-cardinbattle-tanks/styles.cssto includebox-sizing:border-box,max-height:100%,overflow-y:auto, andoverscroll-behavior:containand remove the clippingoverflow:hiddenbehavior.tests/battle-tanks-page.test.jsthat asserts the presence of the scrollable result-card contract and ensuresoverflow:hiddenis not present on.result-card.Testing
npm testand all automated tests passed (168 passed, 0 failed).npm test -- --test-name-pattern='Battle Tanks keeps result actions reachable|Battle Tanks game-over actions'and both tests passed.npm run checkandgit diff --check, both completed without errors.Codex Task