test: derive audit-flagged tolerances, tighten where the maths allows - #49
Merged
Merged
Conversation
…#44) - BandCompressorTests: the knee-width margins drop 0.5 -> 0.05 dB; the mapping is exact in the tested region, so only the 0.01 dB scan resolution plus derivative float noise remains (< 0.04 dB). - EngineTests: the GR-tap margin drops 0.5 -> 0.2 dB, from the soloed mid band's LR4 skirts at 1 kHz (-0.12 dB) plus the deepest-vs-average release droop (0.04 dB). - DetectorTests: the crest-factor margin drops 0.5 -> 0.15 dB, from the BallisticsFilter droop/attack budget on the peak path and the RMS path riding its own ripple top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44 (fleet audit class 3, tolerance-without-derivation). All four flagged sites resolved with in-comment derivations:
BandCompressorTests.cpp:1107/1142— knee-width margins 0.5 -> 0.05 dB. The 100*(W/2)/|T| mapping is exact in the tested region; only the 0.01 dB scan resolution (one step per slope crossing) plus derivative float noise remains: < 3 * 0.01 / 0.8 = 0.04 dB.EngineTests.cpp:602— GR-tap-vs-RMS margin 0.5 -> 0.2 dB. The measured figure includes the soloed Mid band's LR4 skirts at 1 kHz (HP @ 200 Hz -0.014, LP @ 3 kHz -0.107 dB), and the tap publishes the block's deepest gain, below the average by the release droop (1-1/8)*20log10(e)2pi0.5ms/600ms = 0.04 dB. Net < 0.16 dB.DetectorTests.cpp:111— crest-factor margin 0.5 -> 0.15 dB. BallisticsFilter (exp(-2pi dt/tau), JUCE 8.0.14) peak path reads ~0.02 low (release droop 0.027 dB, 512-sample mid-band average); RMS path reads ~0.06 high (5 ms mean-square one-pole leaves 2 kHz ripple whose top the fast-attack ballistics rides). Exact-loop simulation across 44.1/48/96 kHz shows -0.077..-0.083 dB, always low.Verification: full local suite, 182/182 passed with the tighter bounds.