Fix cross-test cache pollution in data pipeline tests - #110
Merged
Conversation
The disk cache was enabled by default during the full test suite, so decorated data-pipeline functions could read stale entries written by unrelated tests (the cache key incorporates the identity of injected mock clients, which is unstable across garbage collection). This caused test_data.py::test_decorated_fetch_strips_cache_valid to intermittently receive a cached price instead of the freshly computed one. - Resolve settings per call in the cached() decorator so that changes to the settings singleton (e.g. cache_enabled toggled in tests) are respected rather than captured once at decoration time. - Add tests/conftest.py with an autouse fixture that disables the disk cache for the suite and pins cache.get_settings to the real function, undoing leaks from tests that reload alloc.lib.cache inside a patch block. Tests that exercise caching directly patch get_settings with their own fake and are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The disk cache was enabled by default during the full test suite, so decorated data-pipeline functions could read stale entries written by unrelated tests (the cache key incorporates the identity of injected mock clients, which is unstable across garbage collection). This caused test_data.py::test_decorated_fetch_strips_cache_valid to intermittently receive a cached price instead of the freshly computed one.
Changes:
Gate: 556 tests pass, ruff clean, mypy clean.