Skip to content

Binning quality score function - #2179

Open
MollyRbio wants to merge 6 commits into
benjjneb:masterfrom
MollyRbio:binning_quals
Open

Binning quality score function#2179
MollyRbio wants to merge 6 commits into
benjjneb:masterfrom
MollyRbio:binning_quals

Conversation

@MollyRbio

Copy link
Copy Markdown

Added the quality score binning function to the errorModels.R file.

@MollyRbio

Copy link
Copy Markdown
Author

Ready for code review

@benjjneb

benjjneb commented Mar 4, 2026

Copy link
Copy Markdown
Owner

@MollyRbio

  1. Can you provide a description of the format of your "binning scheme" R object?
  2. Please change function name to follow the package camel case format. Maybe binQuals would work.
  3. Please add a runnable example using a custom binning scheme
  4. If there are citations (can be web links) supporting the predefined binning schemed, it would be good to add them as comments where those schemes are defined

@MollyRbio

Copy link
Copy Markdown
Author

All recommendations fixed. Also, I used an URL shortener for the NovaSeq link, because it was excessively long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants