fix hx-live chaining with next and previous - #4079
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When chaining .q(), next and previous navigate between siblings, so they need to search within the parent element to find elements that come before or after the current one. But first, last, and plain CSS selectors are looking for descendants, so they should scope their search inside each matched element. The fix uses e.parentElement as the search root for next/previous and e for everything else, giving each directive the natural scope it needs.
Corresponding issue:
#4077
Testing
Added tests
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded