prevent abort exception on sse close event - #4081
Open
MichaelWest22 wants to merge 1 commit into
Open
MichaelWest22 wants to merge 1 commit into
MichaelWest22 wants to merge 1 commit into
Conversation
MichaelWest22
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When hx-sse:close receives its configured event, the cleanup code aborts the fetch controller while parseSSE is still suspended on reader.read(), causing the browser to reject that pending read with an AbortError that has no handler. The fix cancels the reader first so parseSSE exits cleanly before the abort fires.
Corresponding issue:
#4078
Testing
Added tests
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded