fix: include submit button name/value when button owns hx-post - #4082
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: include submit button name/value when button owns hx-post (#4073)
In htmx 4,
__collectFormDatarelied solely onevt.submitterto append a submitbutton's name/value. This is
nullon a click event — only a native form submitpopulates it — so buttons with
hx-postdirectly on them never sent their ownname/value.
Fix: if
submitteris not set andeltis itself a named submit button inside aform, treat
eltas the submitter.This restores the htmx 1.x/2.x behaviour where a submit button's name/value is
always included in the request body.
Corresponding issue:
#4073
Testing
Added tests for various cases
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded