Docs: fix contradictions found auditing #229 - #230
Merged
Conversation
Reviewing the diff as a reviewer turned up five places where pages disagreed with each other, four of them introduced by this branch. data-coverage-retention: the FAQ still answered "How far back does Solana DEX trade data go?" with "roughly the last 30 days", directly contradicting the table added higher up the same page (DEXTrades ~12h, DEXTradeByTokens ~7 days). Updated to name the cube, since the answer depends entirely on which one you ask, and to point at Trading.Trades for the 30-day figure that number actually refers to. Same page, two more FAQ answers were stale against the new content: one advised using combined for history, which currently 500s on every Solana cube, and one described realtime as "about the last few hours" when the measured windows run from ~12h on Solana to ~4 days on EVM Transfers. Both now match the table. Corrected an overstatement I introduced in two places. I wrote that Balances and Holders are "current-state cubes, not time series" and "carry no block dimension". They expose Block.Date but not Block.Time — daily grain, not no grain. As written it contradicted the daily-series query on the end-of-day balances page. solana-dextrades still told readers to use dataset: combined for historical OHLC. Changed to archive, and added a caution that several queries further down the page still use combined and will error until the backend issue is fixed, with the workaround. Verified while auditing: no scratch or harness files committed, no unintended deletions, details/summary blocks balanced across all changed files, no BalanceUpdates left inside a block labelled as migrated, and the PR's 21/44 migration claim matches the tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #229, which merged at
8bcb8a16. This is the single commit pushed after that merge.Auditing the merged diff as a reviewer turned up five places where pages disagreed with each other. Four were introduced by #229, and three are live contradictions inside what was just merged.
Fixes
data-coverage-retention.mdxcontradicted itself. #229 added a measured Solana table (DEXTrades~12h,DEXTradeByTokens~7 days) but left an FAQ on the same page answering "How far back does Solana DEX trade data go?" with "roughly the last 30 days". Two different answers on one page. Now names the cube, since the answer depends entirely on which one you ask, and points atTrading.Tradesfor the 30-day figure that number actually refers to.Same page, two more stale FAQ answers. One advised using
combinedfor history, which currently returns a 500 on every Solana cube — documented three sections above it. One described realtime as "about the last few hours" against measured windows of ~12h on Solana to ~4 days on EVM Transfers.An overstatement I introduced, in two places. I wrote that
Balances/Holdersare "current-state cubes, not time series" and "carry no block dimension". They exposeBlock.Datebut notBlock.Time— daily grain, not no grain. As written it contradicted the daily-series query on the end-of-day balances page from the same PR.solana-dextrades.mdxrecommendeddataset: combinedfor historical OHLC (pre-existing, not from #229). Changed toarchive, plus a caution that several queries further down that page still usecombinedand will error until the backend issue is fixed, with the workaround.Also verified while auditing
<details>/</details>balanced across every changed fileBalanceUpdatesleft inside a block labelled "Migrated query"Build passes with
onBrokenLinks: throw, 0 broken links.Note on the failure mode
Every one of these came from editing a page section-by-section without re-reading the whole page afterwards. The queries were each verified individually; the prose around them drifted out of agreement. No query-execution audit would have caught it.
Still open from #229, unchanged
BalanceUpdate.Typesubscription has no replacement after the 10 August sunset —Balancesdoes not stream and has noTypeBalances/Holdersare currently less reliable than the cube they replace (retried 3x per chain:Balancesbsc 0/3, matic 1/3, base 3/3, eth 3/3, whileBalanceUpdatesanswered 2/2 on the same runs)