Sync pattern grouping and protect inline code spans - #235
Open
Scott-Emberson wants to merge 1 commit into
Open
Conversation
- SKILL.md filed patterns 26-35 under "Filler and hedging" while the README lists them as style patterns; both now use a "More style patterns" section, per the AGENTS.md sync rule. - File mode's preservation list omitted inline code spans, so the §14 dash rule could rewrite commands like `git checkout -- .` when humanizing a file. The list now matches AGENTS.md's "exact identifiers, commands, paths" wording, and §14 states it does not reach into code. - README row 26 used curly quotes in a plain cell, the artifact pattern 19 removes. Now straight quotes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three related documentation and prompt fixes from a full-repo review:
Pattern grouping drift. SKILL.md's "## Filler and hedging" heading covered patterns 23 through 35, but ten of those (26-35, e.g. §29 repeated headings, §30 previous-version prose) are not filler or hedging, and the README lists them under "Style patterns". AGENTS.md requires keeping the two files in sync, and the validator only checks numbering, so this drift passed CI. Both files now use a "More style patterns" section for 26-35 ("Filler and hedging" keeps 23-25). The README's style table is split at the same boundary so the two documents use one term.
Inline code spans were rewritable in file mode. File mode's preservation list named "code blocks, YAML metadata, data, and link targets" but not inline code spans, while §14 targets
--and §19 straightens curly quotes. Humanizing a Markdown file whose prose containsgit checkout -- .or a curly-quoted identifier could silently corrupt it. The list now uses AGENTS.md's own wording ("inline code spans, exact identifiers, commands, paths"), and §14 states it does not reach into code blocks, inline code spans, commands, paths, or URLs.Curly quotes in README row 26. The Before cell for pattern 26 was wrapped in curly quotes in a plain table cell, the exact artifact pattern 19 removes (row 19's curly quotes are deliberate and sit in a code span; row 26's were not). Now straight quotes.
Validator invariants checked: SKILL.md is 458 lines (limit 500), patterns 1-35 remain sequential, all 35 README rows present. No version bump here to avoid colliding with #233; happy to fold a release note into whichever lands last.
🤖 Generated with Claude Code