Skip to content

fix(mev): align gRPC defaults and preserve active revoke deadlines - #511

Open
flywukong wants to merge 3 commits into
bnb-chain:developfrom
flywukong:support-grpc-config
Open

flywukong wants to merge 3 commits into
bnb-chain:developfrom
flywukong:support-grpc-config

Conversation

@flywukong

@flywukong flywukong commented Sep 16, 2026

Copy link
Copy Markdown

Description

  1. Enable MEV gRPC on port 8552 when mining and BidBlock are enabled.
  2. Add --mev.grpc.disable and expose GRPCEnabled in mev_params.
  3. Prevent shorter revocations from reducing an existing lockout.

related bnb-chain/bsc#3810

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

@flywukong
flywukong requested a review from joey0612 as a code owner September 16, 2026 03:17
@hashdit-bot

hashdit-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Pull Request Review

This Rust-based BSC node change enables the BEP-675 MEV gRPC listener on port 8552 by default when mining and BidBlock are active, adds an explicit disable flag, validates zero-port configurations, and exposes gRPC status through MEV parameters. It also preserves existing builder revoke deadlines when shorter policy or manual revocations are applied and adds tests for the new behavior.

Sensitive Content

Private Key / Seed Phrase / Mnemonic / Secret Material:

  • 0101...0101 (Test private key) in src/node/miner/config.rs — A deterministic 32-byte private key is constructed with "01".repeat(32) in the newly added zero-port validation test.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Pull Request Review

This Rust BSC node PR aligns the BEP-675 MEV gRPC transport with go-bsc defaults by using port 8552, enabling it when mining and BidBlock are active, adding an explicit disable flag, and exposing its configured state through GRPCEnabled. It also changes builder revocation handling so subsequent shorter policy or manual revocations cannot shorten an existing active lockout, with tests covering both behaviors.

Sensitive Content

No sensitive content detected.

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

@hashdit-bot

hashdit-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Pull Request Review

This Rust BSC node change enables the BEP-675 MEV gRPC listener on port 8552 by default when mining and BidBlock are enabled, adds an explicit disable flag/environment setting, and exposes the transport state through GRPCEnabled in MEV parameters. It also changes builder revocation handling so shorter policy or manual revocations cannot reduce an existing active lockout deadline, with tests covering the new behavior.

Sensitive Content

Private Key / Seed Phrase / Mnemonic / Secret Material:

  • 0101...0101 (Private Key) in src/node/miner/config.rs — New test configuration constructs a deterministic 32-byte private key using "01".repeat(32).

Security Issues

No serious security issues detected.


Generated by Hashdit Bot. This tool can absolutely NOT replace manual audits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants