[blockcheck2] Add a coverage summary next to the results - #311
Open
sasha-spb-ru wants to merge 1 commit into
Open
sasha-spb-ru wants to merge 1 commit into
sasha-spb-ru wants to merge 1 commit into
Conversation
When testing several targets at once, the results only ever show strategies that worked for every single one. If your targets are a bunch of unrelated servers, that list can easily come up empty even when several strategies each work for most of them. Adds a second summary that lists every strategy that worked at all, with how many targets it worked for, best first - so you can see which one comes closest instead of getting an all-or-nothing answer.
sasha-spb-ru
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final report's COMMON section only ever shows strategies that worked for every tested domain - a much less likely outcome across a set of largely independent targets (e.g. one IP per hosting ASN) than across mirrors of one real site, where it can easily come up empty even when several strategies each work for most of the targets.
Adds a COVERAGE listing: every distinct successful strategy together with how many of the domains/targets it worked for, most-covered first, so the best-performing strategy is visible even when nothing reaches 100%. Reuses the per-strategy hash/counter bookkeeping
report_append()already maintains for COMMON, so this costs one extra pass over data already being collected rather than any new tracking.