Conversation
Refactor parameter replacement logic for multi-value filters in SelectQuery.
Hoist placeholder to keep the PHPStan ignore count at 1
Contributor
There was a problem hiding this comment.
Copilot review overview
馃煛 Changes recommended
Supported operators and overlapping placeholders can still produce invalid DQL or unused parameters.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Refactors SelectQuery parameter replacement for multi-value content-field filters.
Changes:
- Rebuilds JSON field expressions for multiple bound values.
- Preserves boolean filter structure.
- Requires fixes for operator coverage and placeholder-boundary matching.
| File | Summary |
|---|---|
src/鈥婼torage/鈥婼electQuery.php |
Updates multi-value field-expression and placeholder handling. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+613
to
+615
| $result = str_replace( | ||
| $originalLeftExpression . ' = :' . $parameter, | ||
| str_replace($placeholder, ':' . $parameter, $newLeftExpression), |
Transform every operator in multi-value field filters
Fix formatting issues and ensure proper closure of class.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3808
Refactor parameter replacement logic for multi-value filters in SelectQuery.