[doc] Drop the stray parameter from the on_bool handler docs - #1180
Open
karpovantonme wants to merge 1 commit into
Open
[doc] Drop the stray parameter from the on_bool handler docs#1180karpovantonme wants to merge 1 commit into
karpovantonme wants to merge 1 commit into
Conversation
The handler concept documents on_bool as taking a string_view of the remaining characters, but its declaration is `bool on_bool( bool b, error_code& ec )`. The line is a copy of the one in on_double above it, which really does take one. on_null below has no such line, so this is the only handler affected.
|
An automated preview of the documentation is available at https://1180.json.prtest2.cppalliance.org/libs/json/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-08-03 15:03:51 UTC |
|
GCOVR code coverage report https://1180.json.prtest2.cppalliance.org/gcovr/index.html Build time: 2026-08-03 15:13:50 UTC |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The handler concept in
basic_parser.hppdocumentson_boolas taking the remaining characters:There is no
s. The line is a copy of the one inon_doubleright above it, which does take astring_view.on_nullbelow has no such line, soon_boolis the only handler affected.It matters a little more than a normal typo because this block is the specification users write their own handler against, so it tells them to expect an argument the parser never passes.
One line, comment only. I checked the rest of the library the same way and this is the only mismatch in it.