Fix MATLAB size_t scalar wrapping on LP64 macOS - #195
Merged
Conversation
dellaert
marked this pull request as ready for review
August 11, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
size_tanduint64_tMATLAB conversions through alias-aware primary-template dispatchuint64_targuments and results as MATLAB numeric scalarssize_tanduint64_tround tripsRoot cause
The prior preprocessor guard assumed every LP64 platform aliases
size_ttouint64_t. That is true for common Linux definitions but false on 64-bit macOS, where the types have the same width but distinct underlying C++ types. As a result, macOS omittedunwrap<size_t>and generated calls fell through to the generic error-producing implementation.Using C++ type traits makes the decision from actual type identity instead of platform macros, so macOS, Linux, Windows, and CUDA configurations cannot produce either a missing conversion or duplicate explicit specializations.
Validation
conda run -n py312 python -m pytest tests/test_matlab_wrapper.py -q— 12 passedconda run -n py312 python -m pytest tests -q— 111 passedgit diff --check./update_wrap.sh codex/fix-matlab-size-tgtsam.KalmanFilter(2)constructs successfullygtsam.symbol('x', 1)andgtsam.symbolIndexround-trip successfullyunwrap<size_t>error; its final optional Boost serialization test encountered a separate Homebrew Boost/std::localeallocator abort