[CLOSED] Adding 64 bit binaries for CodeHelper.exe

[core-ai-bot]

Issue by jha-g
Tuesday May 07, 2019 at 16:37 GMT
Originally opened as adobe/brackets#14784

---

have changed the icon for this binary to be same as brackets, corresponding to brackets-shell/Windows-x64 branch PR

---

jha-g included the following code: https://github.com/adobe/brackets/pull/14784/commits

[core-ai-bot]

Comment by jha-g
Tuesday May 07, 2019 at 16:41 GMT

---

@swmitra@vickramdhawal@shubhsnov please have a look, this is corresponding to brackets-shell PR

[core-ai-bot]

Comment by jha-g
Wednesday May 08, 2019 at 08:07 GMT

---

My changes are in forked repo

[core-ai-bot]

Comment by vickramdhawal
Wednesday May 08, 2019 at 10:13 GMT

---

Should the forked repo be brought under or adobe org ? It will be difficult to track the source of this change. Even the readme or wiki needs to be updated to identify the source of the 64bit binary.

[core-ai-bot]

Comment by shubhsnov
Wednesday May 08, 2019 at 14:56 GMT

---

VSCode 64bit binary is still using the 32bit filewatcher, and since you haven't changed anything specific in the source, rather just the build platform, I'm not sure about this.

A better approach would be to raise these forked changes as a PR against upstream, and see the response there.

[core-ai-bot]

Comment by jha-g
Wednesday May 08, 2019 at 17:47 GMT

---

Yes "Any CPU" is good enough. So, don't need 64 bit build,