Skip to content

[CI] Supersede stale pull request workflow runs - #258

Merged
harn-release-bot[bot] merged 1 commit into
mainfrom
ci/economics-safe-efficiency
Oct 21, 2026
Merged

harn-release-bot[bot] merged 1 commit into
mainfrom
ci/economics-safe-efficiency

Conversation

@burin-labs-agent

@burin-labs-agent burin-labs-agent commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

When a pull request receives another update, CI now cancels its older workflow run so stale checks stop competing for runner capacity. Main pushes, merge groups, and manual runs use a unique run ID, preserving every commit's verdict and avoiding GitHub's one-pending-run eviction. All job definitions, required dependencies, test coverage, and token permissions are unchanged. The risk is that evidence for an older PR head ends as canceled; the newest head still runs the full existing workflow, and workflow lint plus the reviewed diff verify the bounded change. This is an initial CI economics improvement; dollar savings need post-merge measurement and are not claimed here.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@burin-labs-agent
burin-labs-agent marked this pull request as ready for review October 21, 2026 00:07
@burin-labs-agent

Copy link
Copy Markdown
Contributor Author

Independent fresh-context review of 16e2b2a792c0c4cc27fded1083b26a144adbc960: no blocking findings.

The full diff only adds workflow concurrency. Pull-request runs share a group only with older runs of the same workflow, event and PR number. Pushes, merge groups and manual runs use their unique run ID, so unrelated main/queue/manual verdicts cannot supersede each other. cancel-in-progress is true only for pull_request; permissions, jobs, required verdicts and runtime pins are unchanged.

The exact-head rollup reports successful CI status, local workflow contract, pinned shipping runtime, all five documentation-checker cases and both reusable-package smoke variants. There are no pending or failing checks. I inspected the complete workflow context and event triggers as well as the diff.

This is a review comment from a separate review agent, not a GitHub approval or a substitute for any required independent account review. No source changes or merge actions were taken.

@kennethsinder kennethsinder added the ship Ship this pull request with the Smart Ship shepherd label Oct 21, 2026 — with ChatGPT Codex Connector

@harn-release-bot harn-release-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. No issues found.

The change aims to stop stale pull-request CI from using runner capacity while keeping each main, merge-queue, and manual run independent. The workflow-level group scopes cancellation to a PR, while unique run IDs isolate other events; that approach serves the goal. Per-job concurrency would add duplication without improving this workflow's run-level scheduling, and the accepted tradeoff is that an older PR head's checks are canceled. Concurrency has one clear owner here, with no competing repository workflow group identified.

Details

Review run:

  • 1 changed file; 0 carry a finding.

@harn-release-bot
harn-release-bot Bot added this pull request to the merge queue Oct 21, 2026
@harn-release-bot

harn-release-bot Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Ship: Landed. On main after 3 min. Remove the ship label to stop.

History (3)
  • 2026-10-21 00:15 UTC Landed: On main after 3 min.
  • 2026-10-21 00:12 UTC Landing: Checking the change together with the changes ahead of it.
  • 2026-10-21 00:11 UTC Ready to land: The change is ready to join the landing queue.

Merged via the queue into main with commit ab8c1f7 Oct 21, 2026
20 checks passed
@harn-release-bot harn-release-bot Bot removed the ship Ship this pull request with the Smart Ship shepherd label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants