Repository navigation
[CI] Supersede stale pull request workflow runs - #258
Conversation
|
Independent fresh-context review of The full diff only adds workflow concurrency. Pull-request runs share a group only with older runs of the same workflow, event and PR number. Pushes, merge groups and manual runs use their unique run ID, so unrelated main/queue/manual verdicts cannot supersede each other. The exact-head rollup reports successful This is a review comment from a separate review agent, not a GitHub approval or a substitute for any required independent account review. No source changes or merge actions were taken. |
There was a problem hiding this comment.
Approved. No issues found.
The change aims to stop stale pull-request CI from using runner capacity while keeping each main, merge-queue, and manual run independent. The workflow-level group scopes cancellation to a PR, while unique run IDs isolate other events; that approach serves the goal. Per-job concurrency would add duplication without improving this workflow's run-level scheduling, and the accepted tradeoff is that an older PR head's checks are canceled. Concurrency has one clear owner here, with no competing repository workflow group identified.
Details
Review run:
- 1 changed file; 0 carry a finding.
|
Ship: Landed. On main after 3 min. Remove the History (3)
|
When a pull request receives another update, CI now cancels its older workflow run so stale checks stop competing for runner capacity. Main pushes, merge groups, and manual runs use a unique run ID, preserving every commit's verdict and avoiding GitHub's one-pending-run eviction. All job definitions, required dependencies, test coverage, and token permissions are unchanged. The risk is that evidence for an older PR head ends as canceled; the newest head still runs the full existing workflow, and workflow lint plus the reviewed diff verify the bounded change. This is an initial CI economics improvement; dollar savings need post-merge measurement and are not claimed here.
Need help on this PR? Tag
@codesmith-botwith what you need.