fix zsh special character escaping - #1212
Open
darshan-Jahagirdar wants to merge 1 commit into
Open
darshan-Jahagirdar wants to merge 1 commit into
darshan-Jahagirdar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1207.
This keeps
_describe's colon escaping, but stops re-escaping backslashes after zsh-special characters have already been escaped byquoteValue. Values such asTest2&Testaaa.txtandspaceT TT.xnow reach the zsh_describevalues array with a single escaping backslash instead of a doubled one.Validation:
go test ./internal/shell/zshgo test ./...was also run on Windows, but unrelated existing Windows/path and fixture expectation failures remain outside this change area (TestActionDirectories,TestActionFiles, generated shell snippet fixture executable names,TestContextAbs,pkg/uid/TestExecutable).