Skip to content

Adjust IsReadable() for Termux environment without pthread_cancel() - #6249

Open
craigcomstock wants to merge 5 commits into
cfengine:masterfrom
craigcomstock:CFE-4401-2/master
Open

Adjust IsReadable() for Termux environment without pthread_cancel()#6249
craigcomstock wants to merge 5 commits into
cfengine:masterfrom
craigcomstock:CFE-4401-2/master

Conversation

@craigcomstock

@craigcomstock craigcomstock commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@craigcomstock

Copy link
Copy Markdown
Contributor Author

Wanted to post this PR to get github's opinion on the changes. The commits have been in the works for a long time and need to be adjusted as they include gradual changes and improvements that should be collected into fewer commits. Will do soon.

@olehermanse
olehermanse requested a review from larsewi July 29, 2026 13:32
@craigcomstock
craigcomstock marked this pull request as ready for review July 29, 2026 13:41
@craigcomstock

Copy link
Copy Markdown
Contributor Author

Wanted to post this PR to get github's opinion on the changes. The commits have been in the works for a long time and need to be adjusted as they include gradual changes and improvements that should be collected into fewer commits. Will do soon.

they have been reworked. ready to go.

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to bump libntech in 42daf08? If so, it should probably go to a separate commit. Furthermore, the last commit message title is a bit confusing. Otherwise LGTM

instead use MaskTerminationSignalsInThread() from libntech

Ticket: CFE-4401
Changelog: title
AC_CHECK_FUNCS apparently doesn't take into account the __ANDROID_API__ level properly and so incorrectly determines that copy_file_range is available for termux at API 24 but copy_file_range is <= 34.

Ticket: none
Changelog: none
The re-entrant versions of srand() and friends aren't technically required and not using them enables compilation on platforms without glibc.

Ticket: none
Changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants