Skip to content

Version Packages - #938

Open
github-actions[bot] wants to merge 1 commit into
mainfrom
changeset-release/main
Open

Version Packages#938
github-actions[bot] wants to merge 1 commit into
mainfrom
changeset-release/main

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

The changelog information of each package has been omitted from this message, as the content exceeds the size limit.

stash@1.2.0

@cipherstash/nextjs@4.2.0

@cipherstash/protect-ffi@0.33.0

@cipherstash/stack@1.2.0

@cipherstash/stack-prisma@1.2.0

@cipherstash/eql@3.0.6

@cipherstash/stack-drizzle@1.2.0

@cipherstash/stack-supabase@1.2.0

@cipherstash/wizard@1.2.0

@cipherstash/protect-ffi-darwin-arm64@0.33.0

@cipherstash/protect-ffi-darwin-x64@0.33.0

@cipherstash/protect-ffi-linux-arm64-gnu@0.33.0

@cipherstash/protect-ffi-linux-x64-gnu@0.33.0

@cipherstash/protect-ffi-linux-x64-musl@0.33.0

@cipherstash/protect-ffi-win32-x64-msvc@0.33.0

@cipherstash/e2e@0.0.6

@cipherstash/basic-example@1.2.17

@cipherstash/prisma-example@0.1.3

@cipherstash/bench@0.0.8

@cipherstash/ffi-integration-tests@1.0.1

@cipherstash/test-kit@0.0.4

@github-actions
github-actions Bot requested a review from a team as a code owner August 21, 2026 06:37
@github-actions
github-actions Bot force-pushed the changeset-release/main branch 7 times, most recently from 77d81a8 to e796adc Compare August 26, 2026 01:56
@github-actions
github-actions Bot force-pushed the changeset-release/main branch from e796adc to 935828a Compare August 31, 2026 01:29

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes — not because the generated diff is wrong (mechanically it's correct, see below), but because merging it in the repo's current state produces a fully blocked release, and one required pre-merge step for the FFI half hasn't happened. This review is the checklist for whoever drives the release.

Why merge-now fails

  1. @cipherstash/eql is bumped to 3.0.6, but it is still a frozen publisher. scripts/release-gate.mjs on live main still carries the @cipherstash/eql entry in FROZEN_PUBLISHERS, npm has only up to 3.0.5, and the gate exits non-zero when a frozen package's committed version is missing from the registry. Merging this PR therefore fails the gate job and skips release entirely — nothing ships, including @cipherstash/protect-ffi 0.32.1 and @cipherstash/stack-prisma 1.2.0. Note that no CI ran on changeset-release/main at all ("no checks reported"), so nothing surfaced this on the PR; the failure would arrive post-merge.

    Two ways out, both preceding the merge:

    • Do the Phase-5 cutover first: delete the @cipherstash/eql entries from FROZEN_PUBLISHERS and FROZEN_ARTEFACT_DIGESTS (they must go together — release-gate.test.mjs pins that), update the three documents frozen-publisher-docs.test.mjs holds (AGENTS.md, SECURITY.md's publishing note, the gate map itself), and confirm the two cutover prerequisites AGENTS.md says no workflow can assert: the GPG_PRIVATE_KEY secret for release-plz, and write access to ghcr.io/cipherstash/postgres-eql. That arms the whole five-artefact EQL pipeline, which is presumably the intent given .changeset/eql-repoint-manifests-to-stack.md is in this release.
    • Or defer the EQL release: pull the EQL changesets from main and let the bot regenerate this PR without the 3.0.6 bump.
  2. Seven FFI packages move to 0.32.1, and ffi-preflight.yml has not been dispatched against this branch. AGENTS.md requires the preflight dry run against the Version Packages branch before merging a release that moves an FFI version (there is no --dry-run on changeset publish; the preflight is the only rehearsal). The last preflight runs are from 19 Aug on other branches — and the most recent one on main failed. Dispatch it against changeset-release/main and get it green before merging.

What I verified is right in the diff

  • The EQL lockstep held: crate eql-bindings → 3.0.6, COMMENT ON SCHEMA eql_v3 IS '3.0.6' stamped in both copies of the install bundle, both release-manifest.json files, and src/generated/release-manifest.ts all move together — sync-lockstep-versions.mjs ran as designed, and the eql-sql-asset-freshness invariants hold in this tree.
  • All seven protect-ffi packages move in lockstep to 0.32.1; the platform packages match the wrapper.
  • No parked .md.deferred changesets are being consumed; the changesets folded in match what was pending on main.

Once the frozen-publisher question is resolved one way or the other and a green ffi-preflight exists for this branch, I'm happy to re-review — the generated content itself is sound.

@github-actions
github-actions Bot force-pushed the changeset-release/main branch 2 times, most recently from f54b74a to 543943a Compare August 31, 2026 02:37

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after the bot regenerated the branch (543943a, now folding in the changesets from #948/#951-family merges). Both blockers from my previous review are unchanged and still stand: (1) @cipherstash/eql is still bumped to 3.0.6 while live main's FROZEN_PUBLISHERS still freezes it and npm stops at 3.0.5 — merging fails the release gate and ships nothing; do the Phase-5 cutover first or defer the EQL changesets. (2) Seven FFI packages still move with no ffi-preflight.yml run against this branch (latest preflight runs are 19 Aug, and the last one on main failed). The generated lockstep content itself remains mechanically correct. Full checklist in my previous review.

@github-actions
github-actions Bot force-pushed the changeset-release/main branch 3 times, most recently from 8cddd8a to 8741d7a Compare August 31, 2026 23:35

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshing the block over the latest regeneration (8741d7a): both conditions are still unchanged — @cipherstash/eql is still in FROZEN_PUBLISHERS on live main while this PR bumps it to 3.0.6 (npm still stops at 3.0.5, so merge fails the release gate and nothing ships), and ffi-preflight.yml has still never run against this branch while seven FFI packages move. Checklist in my first review on this PR stands verbatim.

@github-actions
github-actions Bot force-pushed the changeset-release/main branch 2 times, most recently from 748a145 to b4d25b9 Compare September 2, 2026 04:38

@freshtonic freshtonic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Covering the latest regeneration: conditions unchanged — @cipherstash/eql still frozen in FROZEN_PUBLISHERS on live main while this PR bumps it to 3.0.6 (npm latest is still 3.0.5), and ffi-preflight.yml has still never run against this branch. My original checklist on this PR stands.

@github-actions
github-actions Bot force-pushed the changeset-release/main branch from b4d25b9 to 03f2df2 Compare September 2, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant