Forward workload identity to volume drivers via mount config - #1191
Open
Viktor-Velkov wants to merge 1 commit into
Open
Forward workload identity to volume drivers via mount config#1191Viktor-Velkov wants to merge 1 commit into
Viktor-Velkov wants to merge 1 commit into
Conversation
Rep already knows the authoritative workload identity (process GUID for LRPs, task GUID for Tasks) at the moment it calls volumeManager.Mount, but does not forward it to the volume driver. Volume drivers that validate a mount against the workload's service bindings therefore have to reconstruct that identity out-of-band, which is slow and requires elevated privileges. Enrich the mount config map with the workload identity before calling Mount: _workload_guid: process_guid (LRP) or task_guid (Task) _workload_type: "lrp" or "task" The change is additive and backward-compatible: the original config map is not mutated, containers without a lifecycle tag are unaffected, and drivers that do not read the keys ignore them. The underscore prefix distinguishes these injected keys from broker-supplied config. Signed-off-by: Viktor-Velkov <viktor.velkov@sap.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rep already knows the authoritative workload identity (process GUID for LRPs, task GUID for Tasks) at the moment it calls
volumeManager.Mount, but does not forward it to the volume driver. Volume drivers that validate a mount against the workload's service bindings therefore have to reconstruct that identity out-of-band (e.g. acfdot actual-lrps --cell-idcell-wide scan followed by a DesiredLRP fetch), which is slow (~1–2s typical, seconds under load) and requiressudo+ shell tooling on the cell.This PR enriches the mount
configmap with the workload identity Rep already holds, before callingMount:_workload_guid—process_guid(LRP) ortask_guid(Task)_workload_type—"lrp"or"task"No protocol change is required — the keys ride the existing
configmap, which the Docker plugin'sCreatecall already forwards to the driver. A binding-validating driver can then read the identity directly instead of reconstructing it.Backward compatibility
Breaking change? No. The change is additive:
configmap is not mutated (a copy is enriched);lifecycletag are returned unchanged;Tests
containerstoremount tests continue to pass.Related
Design discussion (cross-component contract, alternatives considered): #1192