Skip to content

refactor: Use metamodel and remove AST based traversal - #154

Merged
coder3101 merged 2 commits into
mainfrom
ashar/jump-with-metamodel
Aug 2, 2026
Merged

refactor: Use metamodel and remove AST based traversal#154
coder3101 merged 2 commits into
mainfrom
ashar/jump-with-metamodel

Conversation

@coder3101

@coder3101 coder3101 commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Includes Phase 3 of #130

It also brings in a lot of refactoring and removal of old AST based approach.

Signed-off-by: Ashar <ashar786khan@gmail.com>
Signed-off-by: Ashar <ashar786khan@gmail.com>
@coder3101 coder3101 changed the title refactor: Use metamodel and remove all Treesitter AST based traversal refactor: Use metamodel and remove AST based traversal Aug 2, 2026
@coder3101
coder3101 merged commit 3797b64 into main Aug 2, 2026
6 checks passed
@coder3101
coder3101 deleted the ashar/jump-with-metamodel branch August 2, 2026 20:14
Comment thread src/model/mod.rs

@AlexCannonball AlexCannonball Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coder3101 Hello, I'd like to explain, why it wasn't mod.rs in #145

https://doc.rust-lang.org/reference/items/modules.html#module-source-filenames

Prior to rustc 1.30, using mod.rs files was the way to load a module with nested children. It is encouraged to use the new naming convention as it is more consistent, and avoids having many files named mod.rs within a project.

I decided not to touch all the modules and focus on the Phase 1.

If you are aligned with the modern approach, we can plan refactoring to remove mod.rs files.

@coder3101 coder3101 Aug 5, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually prefer to keep using mod.rs. With this, all the files of a module are in a single directory which I prefer over the new convention. We also don't have any nested modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants