Preserve literal IPv6 origins during CORS configuration - #414
Open
jackwalkerlabs wants to merge 1 commit into
Open
jackwalkerlabs wants to merge 1 commit into
jackwalkerlabs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An allowed origin such as
http://[::1]:8000is currently compiled as a regex because of its brackets, so requests from that exact origin receive no allow-origin header. Recognize complete IPv6 origins during origin resolution and retain literal matching. Explicit/compiled regex origins keep their existing behavior.Fixes #396.
Validation: seven new cases fail on the base; all nine IPv6 cases pass after the change.
make checkpasses (locked dependencies, mypy, deptry);make testpasses with 107 passed and one existing skip. Ruff lint/format checks pass for changed files. Coverage includes extension/decorator use, case-insensitive matching, different-address/port rejection, regex compatibility, and requests without an Origin header.AI disclosure: Implemented, reviewed, and tested by OpenAI Codex under the account owner’s authorization; no human code review is claimed.