fix: adjust styles for TWAP EOA tracker order details expand button - #8055
fix: adjust styles for TWAP EOA tracker order details expand button#8055Danziger wants to merge 5 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 11 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe shared Accordion styles now define updated spacing, colors, typography, radii, and transitions. The TWAP confirmation details use ChangesAccordion trigger update
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change only adjusts the TWAP order-details expand button and shared Accordion styling; it does not alter application behavior, data handling, permissions, or deployment. No actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description provides an on-topic summary, testing instructions, and a screenshot. The optional Background section and Self-checks checklist are omitted, but the core description is complete enough for this change. ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ AI Review (Cursor Grok 4.6, worked 2m): Order details accordion matches the Figma splitReview completed. I found no comments worth posting.
Review scope and related contextBranch This is separate from PR 7989, which deferred the smaller Order details label. Generated using the |
fairlighteth
left a comment
There was a problem hiding this comment.
✅ Manual verification: expanded chevron color does not match the label
- In the expanded state, “Order details” renders in primary blue while the chevron remains muted gray.
⚠️ AI Review (Codex GPT-5, worked 9m): expanded chevron keeps the muted color
Finding: [NON-BLOCKING] Match the expanded chevron color to the label
- Location:
Accordion.styled.ts:75 - The expanded trigger label changes to
COLOR_PRIMARY, butChevronretainsCOLOR_TEXT_OPACITY_50; its open-state rule only rotates it. - This leaves the active chevron muted instead of matching the blue label shown in the Figma target.
Suggested fix
- Set the chevron to
COLOR_PRIMARYunder${Trigger}[data-panel-open] &. - Include
colorin its transition if the change should animate.
🤖 Prompt for AI agents
Verify this finding against the current PR head and attached visual target.
Context:
- libs/ui/src/pure/Accordion/Accordion.styled.ts
- The expanded trigger label becomes COLOR_PRIMARY.
- The Chevron remains COLOR_TEXT_OPACITY_50 and only rotates.
- Update the expanded chevron to match the primary label while keeping the collapsed chevron muted.
Generated using the pr-review skill from the CoW Protocol skills repo.
Summary
Minor styling adjustments based on Figma comments.
To Test
Check Figma comments in the "Order details" expand button and verify the new styles match that:
Summary by CodeRabbit