[tools/check] Combine grep/sed calls using "-e".#9225
Open
tkoeppe wants to merge 1 commit into
Open
Conversation
This reduces the number of subprocesses that are spawned.
jwakely
approved these changes
Jul 23, 2026
notadragon
reviewed
Jul 23, 2026
| sed -n 's,//.*$,,;s/%.*$//;s/"[^"]*"/""/;/begin{itemdecl}/,/end{itemdecl}/{/[^-_a-z]\('"$patt"'\)[^-_a-z();,]/{/concept{[a-z_-]*}/d;=;p;};}' $f | | ||
| # prefix output with filename and line | ||
| sed '/^[0-9]\+$/{N;s/\n/:/;}' | sed "s/.*/$f:&/" | | ||
| sed -e '/^[0-9]\+$/{N;s/\n/:/;}' -e "s/.*/$f:&/" | |
Contributor
There was a problem hiding this comment.
You can do a grep -v with sed too.
sed -e '/^[0-9]\+$/{N;s/\n/:/;}' -e "s/.*/$f:&/" \
-e "/@.seebelow/d" \
-e "s/\$/ -- concept name without markup/" |
fail || failed=1
Contributor
Author
There was a problem hiding this comment.
Oh, just by deleting the matching lines? Not bad!
jensmaurer
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces the number of subprocesses that are spawned.