Skip to content

update dependencies - #39

Merged
dancergraham merged 5 commits into
mainfrom
copilot/revert-last-commit-skip-pytest
Jun 10, 2026
Merged

update dependencies#39
dancergraham merged 5 commits into
mainfrom
copilot/revert-last-commit-skip-pytest

Conversation

@dancergraham

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 10, 2026 09:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s Rust/Python packaging and runtime dependencies (PyO3/numpy/maturin) and adjusts the Rust→NumPy array construction accordingly, with accompanying CI and lockfile updates.

Changes:

  • Bump Rust crates (pyo3, numpy, e57) and update src/lib.rs to use PyArray2 + IntoPyArray.
  • Update Python packaging metadata (maturin minimum, numpy>=2,<3, add optional test extra, add version).
  • Add Cargo.lock and adjust CI matrix/conditions (including dropping macOS x86_64).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/lib.rs Updates NumPy/PyO3 bindings to newer numpy crate APIs and PyArray2 types.
pyproject.toml Updates build requirements and Python dependency constraints; adds version + optional test deps.
Cargo.toml Bumps Rust dependencies (pyo3, numpy, e57) and removes direct ndarray dep.
Cargo.lock Newly added lockfile reflecting updated Rust dependency graph.
.github/workflows/CI.yml CI matrix/conditions adjusted for new tooling and platform coverage changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment thread .github/workflows/CI.yml
@dancergraham

Copy link
Copy Markdown
Owner Author

@copilot ith:
arch: x86_64
distro: alpine_latest
githubToken: ***
install: apk add py3-virtualenv

run: set -e

python3 -m virtualenv .venv
source .venv/bin/activate
pip install pytest
pip install e57 --find-links dist --force-reinstall
pytest

env:
pythonLocation: /opt/hostedtoolcache/Python/3.13.13/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.13.13/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.13/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.13/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.13.13/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.13.13/x64/lib
CARGO_INCREMENTAL: 0
CARGO_TERM_COLOR: always
ACTIONS_CACHE_URL: https://acghubeus2.actions.githubusercontent.com/D29snhb6MUPbvRtyhbOFNtkO8PZMT4jKV254wfkpwkMFxBMmem/
ACTIONS_RUNTIME_TOKEN: ***
SCCACHE_GHA_ENABLED: true
RUSTC_WRAPPER: sccache
PYO3_USE_ABI3_FORWARD_COMPATIBILITY: 1
Error: run-on-arch: /home/runner/work/_actions/uraimo/run-on-arch-action/v2/Dockerfiles/Dockerfile.x86_64.alpine_latest does not exist.

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@copilot ith:
arch: x86_64
distro: alpine_latest
...

Fixed in the latest commit. The uraimo/run-on-arch-action only supports emulated (non-native) architectures — x86_64 doesn't have a corresponding Dockerfile in that action. Changed the condition in the musllinux pytest step from matrix.platform.target != 'x86' to !startsWith(matrix.platform.target, 'x86'), which also excludes x86_64 from the run-on-arch step. This mirrors the same pattern already used in the linux job.

@dancergraham
dancergraham merged commit 1a8febe into main Jun 10, 2026
11 checks passed
@dancergraham
dancergraham deleted the copilot/revert-last-commit-skip-pytest branch June 11, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants