Accept, verify, and expose Sigstore package attestations - #9544
Closed
mosuem wants to merge 2 commits into
Closed
Conversation
Implements Sigstore attestation support in pub-dev using package:sigstore: - Adds `AssetKind.attestation` for storing attestation bundles as package version assets in Datastore. - Exposes `GET /api/packages/<package>/versions/<version>/attestation` endpoint to serve attestation bundles. - In `packageBackend.publishUploadedBlob`, checks for accompanying `tmp/<guid>.sigstore.json` in the incoming bucket, verifies it against the uploaded package archive, name, version, and pubspec repository using `AttestationVerifier`, and rejects uploads with invalid attestations. - Updates `PubApiClientExt` and adds unit tests in `upload_test.dart`.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements package attestation support on pub.dev using
package:sigstore:Features
packageBackend.publishUploadedBlob, checks for an accompanying attestation bundle (tmp/<guid>.sigstore.json) in the incoming bucket.AttestationVerifierfrompackage:sigstore.AssetKind.attestationfor storing verified attestation JSON as aPackageVersionAsset.GET /api/packages/<package>/versions/<version>/attestationfor the pub client and tools to retrieve the attestation bundle.PubApiClientExtto support uploading attestation bundles alongside archive bytes.app/test/package/upload_test.dart.