[skills] Support ug skill remove --mcp --location - #589
Merged
Merged
Conversation
xsh310
added this pull request to stack #576
September 13, 2026 06:55
xsh310
marked this pull request as ready for review
September 13, 2026 07:01
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 14, 2026 03:08
51928ed to
2ef898c
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 14, 2026 20:09
2ef898c to
9970f3d
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 14, 2026 22:32
9970f3d to
098a2c7
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 14, 2026 23:20
098a2c7 to
273b512
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 15, 2026 01:41
273b512 to
2c1f508
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 15, 2026 03:40
2c1f508 to
05f1967
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 15, 2026 04:42
05f1967 to
e760266
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
2 times, most recently
from
September 15, 2026 18:17
9adc356 to
fc3fd5a
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 15, 2026 19:56
fc3fd5a to
184e027
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
2 times, most recently
from
September 15, 2026 23:20
921b423 to
c124b65
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
2 times, most recently
from
September 15, 2026 23:42
3b788c4 to
26f9aca
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
2 times, most recently
from
September 16, 2026 00:10
69d4f6a to
76f2897
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 16, 2026 00:52
76f2897 to
a718f9a
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
2 times, most recently
from
September 16, 2026 03:59
33d7603 to
86b6a52
Compare
xsh310
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
September 16, 2026 05:19
xsh310
force-pushed
the
skills-mcp-remove-location
branch
2 times, most recently
from
September 16, 2026 19:03
76f2897 to
5f3249d
Compare
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 16, 2026 19:11
5f3249d to
c8dc6e8
Compare
sunishsheth2009
approved these changes
Sep 16, 2026
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 16, 2026 20:08
c8dc6e8 to
60d31b1
Compare
`ug skill remove --mcp` was interactive-only; the non-interactive counterpart to `ug skill add --mcp --location` was missing. Passing `--location` now drops the named `<catalog>.<schema>` schemas from the skills MCP scope without a picker, and `--mcp` with no `--location` on a non-interactive terminal errors asking for it (matching the add path) instead of falling into an unusable picker. The removal core moves into `remove_skill_locations_from_mcp`, shared by the interactive `remove_skills_command` and the new `remove_skills_locations_command`, mirroring the `add_skill_locations_to_mcp` split. `--agents` scopes removal to the named clients as before; `--path` and `--skills` stay rejected with `--mcp`. Co-authored-by: Isaac <no-reply@databricks.com>
xsh310
force-pushed
the
skills-mcp-remove-location
branch
from
September 16, 2026 20:21
60d31b1 to
4216a05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ug skill remove --mcpwas interactive-only. This adds--locationsupport so a specific set of<catalog>.<schema>schemas can be dropped from the skills MCP connection's scopenon-interactively, and makes the no-
--locationcase behave likeug skill add --mcp: a picker onan interactive terminal, a clear error otherwise.
Why
ug skill add --mcp --location(and its picker, from #588) had no removal counterpart. Scripts andnon-interactive callers could not remove a schema from the MCP scope, and
ug skill remove --mcpina non-interactive shell fell into a picker that cannot be used. This makes the add and remove paths
symmetric.
How
skills_remove):--mcpnow accepts--location. With locations it calls the newremove_skills_locations_command; with none it opens the existing picker on a TTY, otherwise iterrors asking for
--location.--pathand--skillsstay rejected with--mcp, and--agentsscoping is unchanged.
remove_skill_locations_from_mcp, shared by the interactiveremove_skills_commandand the new non-interactive command, mirroring [skills] Add an interactive schema picker toug skill add --mcp#588'sadd_skill_locations_to_mcpsplit. A schema not in scope is a no-op.Testing
uv run ruff check,ruff format --check,ty check src, anduv run pytestall pass (thepre-existing
test_e2e_user_agent/test_claude_smart_routing_v2failures also fail on the base).Added tests for
remove_skills_locations_command(per-client removal, agent scoping, anot-in-scope no-op, and the schema-less connection kept when the last schema is removed) and for the
CLI dispatch (
--mcp --location, agent scope, the non-interactive no---locationerror, a malformedlocation, and
--path/--skillsrejection).Stack
Part of gh stack #576, on top of #588 (
skills-mcp-add-picker).This pull request and its description were written by Isaac.
Stack created with GitHub Stacks CLI • Give Feedback 💬