Reassure users while the picker loads more rows - #618
Merged
Merged
Conversation
xsh310
added this pull request to stack #576
September 14, 2026 20:47
xsh310
marked this pull request as ready for review
September 14, 2026 20:48
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 14, 2026 22:32
5ed93f9 to
7a7d7ea
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
2 times, most recently
from
September 15, 2026 01:41
793c664 to
4b7b880
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 15, 2026 03:40
4b7b880 to
12153f4
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 15, 2026 04:42
12153f4 to
3364135
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 15, 2026 14:43
3364135 to
33c337c
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 15, 2026 18:17
33c337c to
1d35ee9
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
2 times, most recently
from
September 15, 2026 21:19
92e6df1 to
3ece429
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
2 times, most recently
from
September 15, 2026 23:32
f8d82cc to
58a7055
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 15, 2026 23:42
58a7055 to
5bec34e
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 15, 2026 23:50
5bec34e to
bd18531
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 00:10
bd18531 to
580005e
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 00:52
580005e to
6eef796
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
2 times, most recently
from
September 16, 2026 03:59
b273042 to
9d95a4d
Compare
xsh310
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
September 16, 2026 05:19
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 05:19
9d95a4d to
580005e
Compare
sunishsheth2009
approved these changes
Sep 16, 2026
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 19:03
580005e to
9974808
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 19:11
9974808 to
f0038d7
Compare
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 20:08
f0038d7 to
61aedc4
Compare
The streaming picker footer read "⏳ loading more <noun>…" during the background walk, which can read like a hang. Reword it to "⏳ Loading more <noun>, this might take a few seconds..." so the wait reads as expected. All three pickers (skills, skill schemas, MCP services) share this footer. Co-authored-by: Isaac <no-reply@databricks.com>
xsh310
force-pushed
the
skills-picker-loading-copy
branch
from
September 16, 2026 20:21
61aedc4 to
973c187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed, and why?
Change: Reword the streaming picker's loading footer in
src/ucode/ui/interactive_picker.pyfrom⏳ loading more <noun>…to⏳ Loading more <noun>, this might take a few seconds... (<n> found).Why: The catalog walk behind the picker scans every schema in the workspace and can take a few seconds, and the old terse footer read like a hang. The new copy tells the user the wait is expected. The footer is shared, so all three streaming pickers pick it up:
⏳ Loading more skills, this might take a few seconds... (0 found)⏳ Loading more skill schemas, this might take a few seconds... (0 found)ug mcp add→⏳ Loading more MCP services, this might take a few seconds... (0 found)How do you know it works?
Testing:
uv run ruff check .is clean, andtests/test_interactive_picker.py,tests/test_skills_download.py, andtests/test_mcp.pyall pass (234 tests). No test asserted the literal footer text; the twoloading_nounassertions still hold, since the caller arguments are unchanged.This pull request and its description were written by Isaac.