Fix TypeError when completion metadata is bytes#1612
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
When the client encoding is one psycopg cannot decode (e.g. SQL_ASCII), catalog identifiers such as schema names come back as bytes. escape_name then matched a str regex against them and raised "TypeError: cannot use a string pattern on a bytes-like object", killing the completion_refresher thread so completions never loaded. escape_name now decodes bytes with the replacement error handler before matching, so completion degrades gracefully instead of crashing. Closes dbcli#1405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1405
Description
When the client encoding is one psycopg cannot decode (e.g.
SQL_ASCII), catalog identifiers come back asbytes.PGCompleter.escape_namematched astrregex against them and raisedTypeError: cannot use a string pattern on a bytes-like object, which killed thecompletion_refreshthread so completions never loaded. It now decodes bytes with thereplaceerror handler first, matching thePGCLIENTENCODING=utf8workaround users found.Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install).mainwith the reportedTypeErrorand passes with the fix;tests/test_pgcompleter.pyplus the completion suites are green, ruff check/format clean).