BKG 2.0, EBL 3.0: SD-3141, SD-3133: Add FF to references

[HenrikHL]

SD-3141: Add FF to Booking references
SD-3133: Add FF to eBL modules

[qodo-code-review]

PR Summary by Qodo

Add FF (Freight Forwarder) reference type across BKG 2.0 and eBL 3.0 specs

✨ Enhancement 📝 Documentation 🕐 Less than 10 minutes

AI Description

• Add FF (Freight Forwarder Reference) to allowed booking reference type codes.
• Add FF to eBL and eBL Issuance reference type code enums.
• Align PINT eBL reference type code enums with the new FF value.

Diagram

graph TD
  C["API clients"] --> B["BKG v2 spec"] --> R["ReferenceType codes"]
  C --> E["EBL v3 spec"] --> R
  C --> I["EBL issuance spec"] --> R
  C --> P["PINT eBL spec"] --> R
  subgraph Legend
    direction LR
    _ext["External/Consumers"] ~~~ _spec["OpenAPI Spec"] ~~~ _enum["Enum/Value set"]
  end

Loading

High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize reference codes in a shared component file

• ➕ Avoids repeating the same enum list across multiple specs
• ➕ Reduces risk of future drift between BKG/EBL/ISS/PINT
• ➕ Simplifies future additions (single change point)
• ➖ May require build/packaging changes (bundling/flattening refs)
• ➖ Could be harder for consumers who expect fully self-contained YAML outputs

2. Generate enums from a single source-of-truth (codegen step)

• ➕ Guarantees consistency across all published artifacts
• ➕ Enables automated validation that all specs share the same code set
• ➖ Adds tooling complexity to the repo/release pipeline
• ➖ Harder to apply for small one-off changes without existing generation infrastructure

Recommendation: The current approach (adding FF directly in each affected spec) is appropriate for a small, urgent alignment change. If reference-type additions become frequent, consider a follow-up to centralize or generate the enum lists to prevent spec drift.

Files changed (4) +8 / -0

Enhancement (4) +8 / -0

BKG_v2.0.5.yamlAllow 'FF' in booking reference type code enums +2/-0

Allow 'FF' in booking reference type code enums

• Adds 'FF' (Freight Forwarder Reference) to the documented/allowed reference type codes in BKG v2.0.5. This enables booking references to carry freight forwarder identifiers without validation errors.

bkg/v2/BKG_v2.0.5.yaml

EBL_v3.0.4.yamlAllow 'FF' in eBL v3 reference type code enums +2/-0

Allow 'FF' in eBL v3 reference type code enums

• Adds 'FF' (Freight Forwarder Reference) to the reference type code lists in the eBL v3.0.4 schema. Keeps reference-type validation consistent for eBL payloads.

ebl/v3/EBL_v3.0.4.yaml

EBL_ISS_v3.0.4.yamlAllow 'FF' in eBL Issuance reference type code enums +2/-0

Allow 'FF' in eBL Issuance reference type code enums

• Adds 'FF' (Freight Forwarder Reference) to the Issuance module’s reference type code enums. Ensures issuance flows accept the same reference code set as core eBL.

ebl/v3/issuance/EBL_ISS_v3.0.4.yaml

EBL_PINT_v3.0.0.yamlAllow 'FF' in PINT eBL reference type code enums +2/-0

Allow 'FF' in PINT eBL reference type code enums

• Adds 'FF' (Freight Forwarder Reference) to the PINT eBL v3.0.0 reference type code lists. Aligns PINT validation and documentation with the eBL modules.

pint/v3/EBL_PINT_v3.0.0.yaml

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗