Conversation
Key exchanges bypass the per-identity, per-session uniqueness check that other mixing messages use. Reject a different key exchange from the same identity in the same session before adding another entry or updating the latest key exchange. Keep the check inside acceptKE so reconsidered orphans follow it as well. Cover direct acceptance and orphan reconsideration, harmless exact duplicates, and acceptance of a key exchange in a distinct session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KE messages bypass the per-identity, per-session conflict check applied to other message types. Apply that check inside acceptKE, where both direct acceptance and orphan reconsideration pass, so a second distinct KE cannot increase the session cache or replace latestKE.
Regression tests fail on the previous code for both arrival orders and pass with this change. They also check that exact duplicates remain harmless and a new session can still accept a new KE. Addresses #3795's missing conflict check; the separate comment about old epochs is not changed, and this does not impose a global cap across distinct sessions.
Validation: mixing module tests pass on Go 1.27.1 and 1.26.8; both new acceptance cases run. Five unrelated mixclient integration tests skip without csppsolver. go vet and formatting/diff checks pass.