wire: Reject invalid tx trees early. - #3815
Merged
Merged
Conversation
jholdstock
approved these changes
Sep 26, 2026
dajohi
approved these changes
Sep 27, 2026
This modifies the code that deals with serializing and deserializing outpoints to be more restrictive and immediately reject any values that result in obviously invalid trees. Such outpoints are always ultimately invalid, so it is preferable to reject them early to avoid unnecessary work that will ultimately be discarded.
This adds explicit tests for reading and writing outpoints independently of the larger structures that contain them. The code is already indirectly tested fairly well since it is used as a part of larger structures that are themselves tested. However, testing the operations independently makes it easier to add specific cases and exercise relevant error paths. The tests also exercise truncated reads and short writes at each serialization boundary.
davecgh
force-pushed
the
wire_early_invalid_tree_reject
branch
from
September 27, 2026 22:59
cfb77e2 to
6f6cf21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the code that deals with serializing and deserializing outpoints to be more restrictive and immediately reject any values that result in obviously invalid trees.
Such outpoints are always ultimately invalid, so it is preferable to reject them early to avoid unnecessary work that will ultimately be discarded.
It also adds explicit tests for reading and writing outpoints independently of the larger structures that contain them.
The code is already indirectly tested fairly well since it is used as a part of larger structures that are themselves tested. However, testing the operations independently makes it easier to add specific cases and exercise relevant error paths.
Finally, the tests also exercise truncated reads and short writes at each serialization boundary.