compiler: Simplify fission#2973
Open
FabioLuporini wants to merge 5 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
==========================================
- Coverage 83.57% 83.55% -0.03%
==========================================
Files 257 257
Lines 53783 53801 +18
Branches 4608 4608
==========================================
+ Hits 44951 44955 +4
- Misses 8035 8048 +13
- Partials 797 798 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
FabioLuporini
force-pushed
the
simplify-fission
branch
2 times, most recently
from
July 16, 2026 21:29
d44b2e3 to
d0379ba
Compare
EdCaunt
reviewed
Jul 24, 2026
EdCaunt
left a comment
EdCaunt
left a comment
Contributor
There was a problem hiding this comment.
One minor comment but seems reasonable
| def scope(self): | ||
| return Scope(exprs=self.exprs) | ||
|
|
||
| @cached_property |
Contributor
Author
There was a problem hiding this comment.
that likely was for homogeneity I didn't even think about that, but yes, you're right.
If you don't mind, I'd drop it (along with the other useless ones in that class) in the subsequent PR
EdCaunt
approved these changes
Jul 24, 2026
FabioLuporini
force-pushed
the
simplify-fission
branch
from
July 24, 2026 14:24
f55f815 to
7f8019b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
without this simplification (which was done in 2021, now it seems unneeded, AFAICT based on the tests I've managed to run...) a new test in PRO would fail
I don't see the logic behind it, so unless CI/CD complains, I'd drop it
It might also be a leftover from some other tweaks that was later undone... not sure!