Repository navigation
#2515: add UrlUpdater for KubeLinter (kube-linter) - #2602
Open
majesteSil wants to merge 7 commits into
Open
majesteSil wants to merge 7 commits into
majesteSil wants to merge 7 commits into
Conversation
Collaborator
Coverage Report for CI Build 37664927752Coverage increased (+0.03%) to 74.231%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions15 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
laim2003
self-requested a review
October 1, 2026 16:07
laim2003
requested changes
Oct 2, 2026
laim2003
left a comment
Contributor
There was a problem hiding this comment.
Thanks @majesteSil, great work, I just found some very minor improvements. Otherwise looks great!
- rename MIN_KUBE_LINTER_VID to MIN_KUBE_LINTER_VERSION_IDENTIFIER (naming convention) - rename local vid to versionIdentifier and improve readability - document the upstream v0.6.5 trailing-space tag that triggers an InvalidPathException
17 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2515
Adds a
UrlUpdaterfor KubeLinter so theide-urlsrepository discovers the versions and download URLs of the newkube-lintertool. This is the first of two PRs for #2515: the commandlet itself follows in a second PR that consumes the URLs discovered here (the commandlet cannot resolve real download URLs until this updater is merged).Implemented changes:
KubeLinterUrlUpdater extends GithubUrlReleaseUpdater— discovers versions from thestackrox/kube-linterGitHub releases and maps the six per-platform/architecture.tar.gzassets (linux / darwin / windows × x64 + arm64).v0.6.8has nowindows_arm64.tar.gz,v0.5.1has nodarwin.tar.gz), so the six<os>_<arch>.urlsfiles are only produced for versions with a complete asset set.UpdateManager.KubeLinterUrlUpdaterTest(WireMock) asserting all six platform/architecture.urlsfiles (with checksum) are created, plus akube-linter-releases.jsonmock.Notes:
namefield (e.g.v0.8.3); thevprefix is stripped viagetVersionPrefixToRemove().darwinname for macOS (notmac), and the version is carried by the release tag (not the file name), so URLs follow the explicit per-OS pattern (as inInsoUrlUpdater).CHANGELOG.adocentry and noLICENSE.adocrow for this PR — precedent for a url-updater-only change (cf. Create InsoUrlUpdater #1905 Inso UrlUpdater) is that those belong to the commandlet PR, which adds the tool to the user-facing tool set.Testing instructions
mvn -o -pl url-updater -am test -Dtest=KubeLinterUrlUpdaterTest -Dsurefire.failIfNoSpecifiedTests=false(
-ambuilds the upstreamide-climodule the url-updater depends on; the flag lets theclimodule pass with no matching test.) Result: 1/1 green.mvn -q verify -pl '!documentation'(Spotless format, Checkstyle lint, build + tests) — green for the changed files (the remaining Checkstyle violations in this module are pre-existing legacy files, out of scope per the ratchet).UpdateInitiator(run nightly via GitHub Actions) will now includeKubeLinterUrlUpdaterand populateide-urlsunderkube-linter/kube-linter/<version>/<os>_<arch>.urls. A manual local run is possible via theUpdateInitiatormain class (seedocumentation/contributing/commandlet-and-url-updater.adoc).Checklist for this PR
mvn clean testlocally all tests pass and build is successful — fullmvn clean testfrom the repo root is avoided on purpose (it triggers the long-running documentation module, see AGENTS.md); instead the pre-commit hook'smvn -q verify -pl '!documentation'(build + all module tests) ran green, and the newKubeLinterUrlUpdaterTestis green.#«issue-id»: «brief summary»enhancement/commandlet; adjust if a more specific updater label is preferred)In Progressand assigned to the contributor (or there is no issue)pom.xml/ updated LICENSE — N/A: no runtime dependency added here (KubeLinter is an installed tool, not a library); theLICENSE.adocrow is added in the commandlet PR.Checklist for tool commandlets
N/A for this PR — this PR only adds the
UrlUpdater, not the commandlet. The commandlet (second PR) will be checked against this list (installation, sandbox,LICENSE.adoc, help texts, dependency install,KUBE_LINTER_VERSION/KUBE_LINTER_EDITION, platform coverage).