Conversation
…they are unknown The section rendered only when a simulation produced one, so a request without a simulation showed no balance changes at all - and an absent section is indistinguishable from a transaction that moves nothing, which is the most dangerous thing this review can imply. The user was left to infer the difference from a notice further up. Render it either way. With an answer it is unchanged, headed `Simulated balance changes`. Without one it is headed `Balance changes` - nothing was simulated, so the old heading would be a claim of its own - and states that OISY cannot determine which assets the transaction moves or how much, as an error rather than a warning, since it describes a question the review could not answer at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The balance-changes section rendered only when a simulation produced one (
{#if nonNullish(preview)}). A request OISY could not simulate therefore showed no balance-changes section at all — and an absent section is indistinguishable from a transaction that moves nothing, which is the most dangerous thing this review can imply.The codebase already holds this principle for the party lists: the partial-review notice exists because "an empty list reads as an answer rather than as a gap". Balance changes was the one place that still vanished silently, leaving the user to infer the difference from a notice further up the modal.
Stacked on #14086.
Changes
Simulated balance changes.Balance changes, since nothing was simulated and the old heading would be a claim of its own. It states that OISY cannot determine which assets the transaction moves or how much, asMessageBox level="error"rather than a warning: it describes a question the review could not answer at all, not something for the user to weigh.npm run i18n.PRODUCT.mdrecords that the section is always present and what each heading means.Tests
npx vitest run src/frontend/src/tests/sol— 78 files, 2134 testsnpm run check/npm run check:tests— 0 errorsnpx eslint src/frontend/src/sol src/frontend/src/tests/solNot visually verified — no screenshot of the section in either theme.
🤖 Generated with Claude Code — Claude Opus 5