Repository navigation
chore(trunk): run lint on Go 1.27.3 with golangci-lint 2.15.0 - #9868
matthewmcneely wants to merge 1 commit into
Conversation
go.mod has required go 1.27.3 since #9864, but trunk still ran the go 1.27.0 runtime with golangci-lint 2.13.1. CI auto-switches to the 1.27.3 toolchain, which writes export data version 5, and the x/tools v0.49.0 importer inside golangci-lint 2.13.1 only reads up to version 4. Package x then fails to load, so every promoted x.SafeMutex method reports as undefined, and trunk flags whichever of those land in a changed hunk: s.orc.RLock undefined (type *Oracle has no field or method RLock) golangci-lint 2.15.0 is built on x/tools v0.52.0 and reads the new export data; locally it reports no new issues on #9747 under the default, integration and integration2 build tags. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Description
This PR bumps trunk's Go runtime to
go@1.27.3and golangci-lint to2.15.0, sotrunk checkcan lint the module again.#9864 moved
go.modtogo 1.27.3, but trunk still pinsgo@1.27.0and golangci-lint2.13.1. CI switches to the 1.27.3 toolchain automatically, and 1.27.3 writes export data version 5. Thex/toolsv0.49.0 importer inside golangci-lint 2.13.1 only reads up to version 4:So package
xfails to load, every promotedx.SafeMutexmethod reports as undefined, and trunk flags whichever of those land in a changed hunk. #9747 hit it first:#9864 itself passed because it changed no Go code. Any PR that touches Go files using
SafeMutex(or anything else inx) will fail the same way until this lands.golangci-lint 2.15.0 is built on
x/toolsv0.52.0 and reads the new export data. I reproduced the failure locally with 2.13.1, then ran 2.15.0 under Go 1.27.3 with the repo config: no new issues on #9747 under the default,integrationandintegration2build tags.Checklist
Conventional Commits syntax, leading
with
fix:,feat:,chore:,ci:, etc.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit