release: v2.3.6 "Sounding" - #394
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR performs the v2.3.6 “Sounding” release cut across the workspace: bumping the workspace version, updating libretro metadata, and refreshing the user- and maintainer-facing release documentation to describe the v2.3.6 release.
Changes:
- Bump workspace/crate versions from 2.3.5 → 2.3.6 (including
Cargo.lock). - Update release-facing surfaces (changelog entry, release notes, README “Current Release”, status/version plan docs).
- Update libretro
.infodisplay_versionto match the new release tag.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Bumps workspace version to 2.3.6. |
Cargo.lock |
Updates workspace crate versions to 2.3.6. |
crates/rustynes-libretro/rustynes_libretro.info |
Updates display_version to v2.3.6. |
CHANGELOG.md |
Adds the [2.3.6] release entry describing the release contents. |
.github/release-notes/v2.3.6.md |
Adds maintainer-authored release notes for v2.3.6. |
README.md |
Updates version badge and “Current Release” section to v2.3.6. |
docs/STATUS.md |
Updates the current-release header block to v2.3.6. |
VERSION-PLAN.md |
Updates the “Current release” narrative to v2.3.6. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The cut. Workspace version 2.3.5 -> 2.3.6, the CHANGELOG [2.3.6] section, the maintainer-authored release body, STATUS.md, VERSION-PLAN.md, the README badge, AGENTS.md and CLAUDE.local.md. The version bump immediately tripped `libretro_info_audit`, which pins the local `.info`'s `display_version` against the workspace manifest. That is the guard working: it exists because v2.3.5 shipped a `.info` whose version had drifted from the crate for eleven days, and it caught this in one run. A gap it CANNOT close remains — RetroArch reads `libretro-super`'s copy, which will still say v2.3.5 after this release, so an upstream PR is a release-time step, on the same trigger the v2.2.9 licence drift set. Two claims in AGENTS.md were true when written and are now false; both are corrected. `libretro-super#2069` merged, so RetroArch reads `GPLv3+`, and `RetroArch#19416` merged, so `rustynes` is in `appstore_cores` — verified against `master` rather than the PR state. Being in the build list is not being installable: it arrives with the next App Store RetroArch build. Only `libretro/docs#1180` is still open. Six standing rules are added to AGENTS.md, each earned by a defect in this release rather than invented: a fix touching one call site of a shared path may not fix the bug and will report that it did; a test asserting "not empty" passes while a second defect remains; prose asserting an intent is how a defect survives releases; `ab_check.sh` benches the reference straight after a ~45-second fat-LTO compile, so read the order-bias control first; "inert on almost every cycle" predicts a win only if the work is actually executed; and the bot ceremony has a third hiding place in plain issue comments. A seventh covers panel state outliving the `Nes` it describes, now funnelled through one `clear_rom_bound_analysis` hook. The CHANGELOG and release notes also record the three defects the RAM Atlas review caught after the feature was written — the dead audio observable, the missing locked-session gate, and the `Inert` verdict for an address that was never perturbed. Verified: workspace clippy, 124 test binaries, version consistent across the manifest, the README badge and the libretro `.info`, and — though this commit touches no core code — AccuracyCoin 141/141 on the authoritative RAM decoder with nestest 0-diff.
…EADME Both files carried a "not fixed by this release" note from the v2.3.5 cut saying RetroArch shows the wrong licence and RustyNES is absent on iOS/iPadOS/tvOS. Both were true when written and both merged upstream on 2026-08-16 — `libretro-super#2069` and `RetroArch#19416`. The v2.3.6 blocks at the top of each file already said so, which made the files internally contradictory: a reader reaching the older passage would take the stale claim as current. Caught in review, and it is the same class as the AGENTS.md corrections in this cut — a release note is written in the present tense and then silently becomes history. Rewritten to say what is true now, including the distinction that matters: being in `appstore_cores` is not being installable. It arrives with the next App Store RetroArch build, on libretro's cadence. `libretro/docs#1180` is the one item still open.
1093b3a to
e7483cb
Compare
|
@coderabbitai full review |
|
Antigravity review (Gemini via Ultra)This PR is a trivial release preparation that bumps versions across the workspace to v2.3.6 and updates the changelog and documentation. Blocking issuesNone found. Suggestions
Nitpicks
Automated first-pass review by |
The v2.3.6 "Sounding" release cut. A sounding is a depth measured with its uncertainty attached, which is what every workstream in this release has in common.
Ceremony
Cargo.toml2.3.5→2.3.6(+Cargo.lock)crates/rustynes-libretro/rustynes_libretro.infodisplay_version→v2.3.6CHANGELOG.md[2.3.6] - 2026-08-17 - "Sounding"with Added / Fixed / Changed / Documented.github/release-notes/v2.3.6.mddocs/STATUS.md,VERSION-PLAN.mdREADME.mdAGENTS.mdCLAUDE.local.mdThe version bump tripped a standing audit, which is the guard working
libretro_info_auditfailed immediately on the bump: it pins the local.info'sdisplay_versionagainst the workspace manifest, and the manifest had moved. That test exists because v2.3.5 shipped a.infowhose version had drifted from the crate for eleven days. It caught this in one run.A known gap remains and is not fixable here: the audit can only see the local copy. RetroArch reads
dist/info/rustynes_libretro.infofromlibretro/libretro-super, which will still sayv2.3.5after this release. That needs an upstream PR at cut time — the same trigger the v2.2.9 licence drift established.Two claims in
AGENTS.mdwere false and are correctedBoth were true when written and have since been resolved upstream:
libretro-super#2069merged 2026-08-16 — RetroArch now readsGPLv3+.RetroArch#19416merged76f60626984a—rustynesis now line 268 ofpkg/apple/update-cores.sh, betweenreminiscenceandsameboy. Verified againstmaster, not the PR state. Being in the build list is not being installable: it arrives with the next App Store RetroArch build, on libretro's cadence.Only
libretro/docs#1180remains open.Six new standing rules in
AGENTS.mdEach earned by a defect in this release rather than invented:
measure_in_place's final restore only; all 21 per-trial restores still cleared the ring.ab_check.shbenchmarks the reference immediately after a ~45 s fat-LTO compile — read the order-bias control before the candidate column.reviews[].bodyread.Plus a seventh on panel state outliving the
Nesit describes, now funnelled through oneclear_rom_bound_analysishook.Not in this release, named so it reads as a decision
perf.rsalready tracks). It reports the game's internal lag only, and says so.Verification
release-auto.ymltags and publishes on final-greenmain; do not tag by hand, it races. PRs run Linux-only whilemainruns the full Windows/macOS matrix, somainCI must go green after merge or the release workflow skips.