Skip to content

packit: fix config - #1475

Merged
joe-lawrence merged 1 commit into
dynup:masterfrom
mfocko:ci/fix-packit-config
Aug 27, 2025
Merged

joe-lawrence merged 1 commit into
dynup:masterfrom
mfocko:ci/fix-packit-config

Conversation

@mfocko

@mfocko mfocko commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .packit.yml Outdated
- Fedora-37-Updated-s390x
- Fedora-37-Updated-ppc64le
skip_build: true
manual_trigger: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the manual_trigger on commit intentional?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be helpful while we are learning how to use service and polishing configs?

- Add note about meaning of `branch` with `pull_request` trigger
- Fix the main branch (main -> master)
- Explicitly map targets
  - Also report a bug with regards to that packit/packit-service#2841
- TF extra params use `environments` (correct the typo)
  - Correct the indentation with `environments[].variables`
- Factor out 1:1 configuration of tests to `_` helper key to lower the
  noise in the diffs

Signed-off-by: Matej Focko <mfocko@redhat.com>
@mfocko
mfocko force-pushed the ci/fix-packit-config branch from d987f9f to fd6f656 Compare August 26, 2025 11:00
@mfocko

mfocko commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

/packit test --labels integration-pr

@joe-lawrence
joe-lawrence merged commit fd6f656 into dynup:master Aug 27, 2025
3 of 6 checks passed
@joe-lawrence

Copy link
Copy Markdown
Contributor

Thanks for the help, @mfocko !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants