Skip to content

fix: keep homepage section order consistent across locales - #77

Merged
hoangsvit merged 6 commits into
mainfrom
fix/home-locale-layout-order
Sep 24, 2026
Merged

hoangsvit merged 6 commits into
mainfrom
fix/home-locale-layout-order

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Summary

  • Add a stable program-countdown-host directly in the shared calculator DOM.
  • Keep the countdown anchor before the Extension section for every homepage locale.
  • Avoid relying only on post-hydration DOM insertion, which could make localized homepages appear in a different order depending on mount timing.
  • Add a regression test that locks the countdown anchor position.

Why

The default and localized homepage sources declare the same component order, but ProgramCountdown previously created its own host dynamically after hydration. Localized routes load catalog/translation work at a different time, so a deterministic server-rendered anchor is safer and keeps layout order identical.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🧹 PR preview removed

The preview for this pull request was removed after the PR was closed.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: dca26ccb-8bae-40de-bbbb-a44951205b42


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-actions Bot added a commit that referenced this pull request Sep 24, 2026
github-actions Bot added a commit that referenced this pull request Sep 24, 2026
github-actions Bot added a commit that referenced this pull request Sep 24, 2026
@hoangsvit
hoangsvit merged commit ddf3011 into main Sep 24, 2026
5 checks passed
@hoangsvit
hoangsvit deleted the fix/home-locale-layout-order branch September 24, 2026 11:36
github-actions Bot added a commit that referenced this pull request Sep 24, 2026

This branch was successfully deployed

1 active deployment
pr-preview — ce8df978 Deployed Sep 24, 2026 by hoangsvit via preview #769
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant