Run full CI on any non-data/non-doc change - #170
Open
DunklesArchipel wants to merge 2 commits into
Open
Conversation
The build/test/validation workflows used allowlist `paths:` filters scoped to data and code dirs, so PRs touching only workflows, util scripts, the lockfile or root config triggered no CI at all. Switch them to `paths-ignore` so any change outside the data/docs fast-path runs the full checks; quick-data-check remains the data-only fast path. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
While working on the
automatic-metadata-version-checkPR (#146), not a single CI workflow ran even though it changedechemdb_ecdata/-adjacent config and added a new workflow. That isn't optimal: a PR can touch the GitHub workflows,util/scripts, the lockfile, or root config and get merged with zero CI coverage.The cause is that the
data(build),TestandValidate Examplesworkflows used allowlistpaths:filters scoped only toliterature/**,echemdb_ecdata/**,pyproject.toml, and their own workflow file. Any change outside that list matched nothing, so all checks were skipped.What
Switch those three workflows from allowlist
paths:to blocklistpaths-ignore:, so that anything outside the data/docs fast-path runs the full checks.Quick Data Checkis left untouched as the data-only fast path.Resulting behavior:
literature/**+ news fragment) →data+Quick Data Checkonly (no Python test matrix).*.md,doc/**) → heavy checks skipped.util/,pixi.lock,pyproject.toml, root config) → fulldata+Test+Validate Examples.This PR is also its own test case: it changes only
.github/workflows/**+doc/news/**, which previously triggered nothing — under the new filters it should now rundata,Test, andValidate Examples.Note
Testis a 5-Python × 3-OS matrix (15 jobs), so it now runs on any non-data/non-doc change. That's intentional for catching breakage, but worth being aware of for CI minutes.🤖 Generated with Claude Code