[GTK] Report the Java caller of a GTK message in debug mode - #3606
Merged
akurtakov merged 1 commit intoSep 21, 2026
Merged
Conversation
GTK is built with G_LOG_USE_STRUCTURED, so its messages never reach the g_log_set_handler() handler in Device.logProc, leaving no way to tell which SWT call provoked a GTK warning. Install a GLib writer function, the only hook that sees them, and append the Java stack to each message. A writer is process-wide, fatal to set twice and impossible to unset, so it is installed only for a device in debug mode. Nothing changes without SWT_DEBUG=1 or DeviceData.debug. Assisted-by: Anthropic Claude Code (claude-opus-5[1m])
Member
Author
|
With this change Gtk/Gdk logging is converted to reports like: that make it easier to spot how to actually come to a problem. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The process-global writer conflicts with GLib’s application-only contract, and the hard-linked APIs exceed SWT’s minimum supported GLib version.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds Java stack traces to GTK structured log messages when SWT debugging is enabled.
Changes:
- Installs a process-wide GLib log writer in debug mode.
- Adds GLib JNI bindings and generated native wrappers.
| File | Description |
|---|---|
Device.java |
Installs and handles the debug log writer. |
OS.java |
Declares GLib writer APIs. |
os.c |
Adds generated JNI implementations. |
os_stats.h |
Registers generated native function identifiers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GTK is built with G_LOG_USE_STRUCTURED, so its messages never reach the g_log_set_handler() handler in Device.logProc, leaving no way to tell which SWT call provoked a GTK warning. Install a GLib writer function, the only hook that sees them, and append the Java stack to each message.
A writer is process-wide, fatal to set twice and impossible to unset, so it is installed only for a device in debug mode. Nothing changes without SWT_DEBUG=1 or DeviceData.debug.
Assisted-by: Anthropic Claude Code (claude-opus-5[1m])