[GTK4] Activate a popover shell when it is pressed - #3616
Merged
akurtakov merged 1 commit intoSep 23, 2026
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Non-primary mouse presses can still trigger the unsafe focus transition without activating the shell.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Activates GTK4 popover-backed shells before focus transitions to prevent disposal during FocusOut.
Changes:
- Adds a capture-phase click gesture to popover shells.
- Marks eligible shells active when pressed.
| File | Description |
|---|---|
Shell.java |
Adds early activation handling for GTK4 popovers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
A press in a popover moves the keyboard focus into it, and the previous focus control gets FocusOut first. Since popovers are no longer made active on show, JFace disposed the Ctrl+hover link popup in that FocusOut, in the middle of GTK's focus change, and GTK then looped forever on gtk_widget_get_parent (NULL). Activate the shell in the capture phase, before the focus moves. Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])
akurtakov
force-pushed
the
gtk4-activate-popover-on-press
branch
from
September 23, 2026 13:46
4d78603 to
9cee6eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A press in a popover moves the keyboard focus into it, and the previous focus control gets FocusOut first. Since popovers are no longer made active on show, JFace disposed the Ctrl+hover link popup in that FocusOut, in the middle of GTK's focus change, and GTK then looped forever on gtk_widget_get_parent (NULL). Activate the shell in the capture phase, before the focus moves.
Assisted-by: Anthropic Claude Code (claude-opus-5-5[1m])