Find/replace overlay: toggle replace visibility instead of recreating it - #4206
Merged
HeikoKlare merged 1 commit intoJul 28, 2026
Conversation
Contributor
HeikoKlare
marked this pull request as ready for review
July 27, 2026 06:47
HeikoKlare
force-pushed
the
findreplace-overlay-always-create-replace-bar
branch
from
July 27, 2026 08:26
094b466 to
48990d7
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors the Find/Replace overlay so the replace bar is created once (alongside the search bar) and then shown/hidden via visibility + layout exclusion instead of being disposed/recreated on every toggle. This simplifies lifecycle handling across the overlay and its command infrastructure.
Changes:
- Replace bar lifecycle changed from create/dispose-on-toggle to always-created and toggled via
setVisible(...)+GridData.exclude. - Command support simplified by removing the separate “replace actions” registration/activation path.
- Tests updated to treat replace widgets as always present and to use visibility rather than null checks to detect “open” state.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/org.eclipse.ui.workbench.texteditor.tests/src/org/eclipse/ui/internal/findandreplace/overlay/OverlayAccess.java | Adjusts UI test access helpers to the replace-bar-is-always-created model. |
| bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlayCommandSupport.java | Consolidates action registration/handler activation management into single lists. |
| bundles/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/findandreplace/overlay/FindReplaceOverlay.java | Implements replace bar show/hide logic and installs focus traversal handling against visibility rather than widget existence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Creating and disposing the replace bar widgets on every toggle forced several call sites to guard against the bar not existing yet (open/close lifecycle methods, null-checks on replaceBar, a separate replace-action activation/deactivation path in the command support). Instead, create the replace bar once alongside the search bar and hide it the same way narrow overlays already hide their toolbars, via changing visibility and adapting the layout data. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
HeikoKlare
force-pushed
the
findreplace-overlay-always-create-replace-bar
branch
from
July 28, 2026 12:35
48990d7 to
e7d345e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The replace bar's widgets used to be created and disposed every time the replace toggle was clicked, which forced several call sites to guard against the bar not existing yet (open/close lifecycle methods, null-checks on
replaceBar, a separate replace-action activation/deactivation path in the command support).The replace bar is now created once, alongside the search bar, and hidden the same way narrow overlays already hide their toolbars: by toggling visibility and adapting the layout data, instead of disposing and recreating the widgets.