Add tests for the unified diff compare editor open path - #2807
Merged
vogella merged 1 commit intoJul 28, 2026
Conversation
Contributor
UnifiedDiffOpenTest pins the behavior of opening a compare editor with the unified diff preference enabled: a workspace-file input with shared document adapters opens a plain text editor with unified diff annotations instead of the compare editor, prepareInput runs exactly once, and an input without shared document adapters falls back to the classic compare editor. One test documents that the unified path currently runs prepareInput on the UI thread; its assertion flips when the preparation moves to a background job. Contributes to eclipse-platform#2795
vogella
force-pushed
the
compare-unified-open-tests
branch
from
July 28, 2026 14:19
0ce2899 to
aca8f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unified diff display had no functional test coverage. UnifiedDiffOpenTest pins the behavior of opening a compare editor with the unified diff preference enabled: a workspace-file input with shared document adapters opens a plain text editor with unified diff annotations instead of the classic compare editor, prepareInput runs exactly once, and an input without shared document adapters falls back to the classic compare editor. One test documents that the unified path currently runs prepareInput synchronously on the UI thread; its assertion is written to flip when a follow-up change moves the preparation onto the background-job pattern the classic editor already uses. This lands ahead of that threading change so the refactoring PR is reviewable against existing, passing pins.
Contributes to #2795